Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

564 add meta editing to the editor #565

Merged
merged 9 commits into from
Sep 14, 2023
Merged

Conversation

vin-ni
Copy link
Member

@vin-ni vin-ni commented Sep 14, 2023

Most of the frontendimplementation is done.
Screenshot 2023-09-13 at 23 36 01

Missing steps:

  • Update Graphql to offer Streamassignment options
  • Update Graphql on backend side to offer AboutText, etc
  • Add StreamingAssignment in Graphql request
  • Subscription for Meta Mutation
  • Validation? (maybe skipable for now, since we don't change the slug)
  • Submit to DB

Could you help me with that @capital-G ?

The idea:
On Meta tab we load all the meta data of the graph. Once we made updates, we can submit those in a summarized mutation. There is no subscription to keep it simple.

Question:
I needed to add the AboutText, Displayname, ... to the GraphDocument Request. Do you think it's ok to extend it, or should we keep it clean and add a second request just for the Metadata?

I'm wondering, because in theory one could add a lot of images to one of these texts, which would in bloat the size of the GraphDocument request a lot. This could possibly lead to a bottleneck increasing the time of loading the editor. Since the data is only necessary if Metadata needs to be exchanged.

On the other hand, uploading incredibly big images to the AboutText would also put that load to the users. So maybe it's then just fair? :P

@vin-ni vin-ni linked an issue Sep 14, 2023 that may be closed by this pull request
12 tasks
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

File Coverage
All files 82%
gencaster/db_logging.py 96%
gencaster/distributor.py 68%
gencaster/schema.py 58%
gencaster/urls.py 76%
osc_server/models.py 91%
osc_server/server.py 55%
story_graph/engine.py 91%
story_graph/markdown_parser.py 91%
story_graph/models.py 96%
story_graph/types.py 93%
stream/frontend_types.py 94%
stream/models.py 92%
stream/types.py 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 1485003

Copy link
Member

@capital-G capital-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this is good as it is right now we can merge it :)

@vin-ni
Copy link
Member Author

vin-ni commented Sep 14, 2023

If you think this is good as it is right now we can merge it :)

I added two more things:

  • Black loading spinner
  • Deactivated buttons if there are no changes

@vin-ni vin-ni merged commit 1928881 into main Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Meta editing to the Editor
2 participants